[wp-trac] [WordPress Trac] #22726: Move 'Insert from URL' tab into the 'Insert Media' tab

[WordPress Trac]

#22726: Move 'Insert from URL' tab into the 'Insert Media' tab
-------------------------------------+-----------------------------
 Reporter:  johnbillion              |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  Media                    |     Version:  3.5
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, javascript
-------------------------------------+-----------------------------
Changes (by kucrut):

 * keywords:  needs-patch => has-patch needs-testing


Comment:

 It took more than what I expected, but I was finally able to make it work.
 What [attachment:22726.3.diff 22726.3.diff] does:
 * Removes the "Insert from URL" menu
 * Adds a new browser router item: "From URL"
 * Manipulate frame's state in `wp.media.view.MediaFrame.Post::_fixState()`
  when changing from/to the ''embed'' state

 The last part feels a bit hacky, but it works :)

 I'm not sure about the workflow so I attached two patches. Please apply
 both patches if you don't want to run `grunt browserify`.

 See also PR for attached patch: https://github.com/xwp/wordpress-
 develop/pull/120

--
Ticket URL: <https://core.trac.wordpress.org/ticket/22726#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform