[wp-trac] [WordPress Trac] #16956: Comments Being Pulled from Non-Existent Post Types
WordPress Trac
noreply at wordpress.org
Fri Sep 11 18:20:21 UTC 2015
#16956: Comments Being Pulled from Non-Existent Post Types
-------------------------------------------------+-------------------------
Reporter: sterlo | Owner:
Type: defect (bug) | boonebgorges
Priority: normal | Status: reviewing
Component: Posts, Post Types | Milestone: 4.4
Severity: normal | Version: 3.1
Keywords: has-patch 2nd-opinion needs-unit- | Resolution:
tests | Focuses:
-------------------------------------------------+-------------------------
Comment (by jorbin):
Sergey made a point that "since r34038, [orphaned comments] can be edited
or removed" via the dashboard. With that in mind, I think Boone's
approach is the right one. It still could lead to unintented information
disclosure. To hopefully help mitigate this from being an issue, I've
updated attachment:16956.8.diff to include a call to `_doing_it_wrong`
when we switch the permission in attachment:16956.9.diff
This still needs unit tests as well before it's ready for commit.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/16956#comment:51>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list