[wp-trac] [WordPress Trac] #33654: wp_new_user_notification breaking change.

[WordPress Trac]

#33654: wp_new_user_notification breaking change.
-----------------------------------------------------+--------------------
 Reporter:  alexander.rohmann                        |       Owner:
     Type:  defect (bug)                             |      Status:  new
 Priority:  normal                                   |   Milestone:  4.3.1
Component:  Users                                    |     Version:  4.3
 Severity:  normal                                   |  Resolution:
 Keywords:  dev-feedback has-patch needs-unit-tests  |     Focuses:
-----------------------------------------------------+--------------------
Changes (by adamsilverstein):

 * keywords:  dev-feedback has-patch => dev-feedback has-patch needs-unit-
     tests


Comment:

 I reviewed the patch, and the previous work on #33358 that led to the
 function change. The _deprecated_argument call is perfect. I think I see a
 stray comma in the function definition for `wp_new_user_notification`
 (L1701)

 [attachment:33654.3.diff]:
 * Refresh against trunk
 * Remove stray comma

 Some unit tests would be nice here and would prevent us from breaking this
 again.

 Should we consider sending a filler instead of blank?  something like
 `{plaintext password removed}`?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33654#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform