[wp-trac] [WordPress Trac] #28617: comments_popup should not be allowed to be access directly

[WordPress Trac]

#28617: comments_popup should not be allowed to be access directly
-----------------------------------+-----------------------------
 Reporter:  eduplessis             |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  Future Release
Component:  Comments               |     Version:  0.71
 Severity:  minor                  |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+-----------------------------
Changes (by johnbillion):

 * keywords:  needs-patch => has-patch 2nd-opinion


Comment:

 In [attachment:28617.diff]:

  * Deprecates and no-ops `get_comments_popup_template()`,
 `is_comments_popup()`, `comments_popup_script()`, and `popuplinks()`.
  * Removes the `comments_popup` parameter in `WP_Query` and the public
 `comments_popup` query var.
  * Removes the comments popup template from the template hierarchy.
  * Removes `theme-compat/comments-popup.php`.

 Combined, this entirely removes the popup comments template functionality.
 If a theme is actually using popup comments, it's going to stop
 functioning as expected with this change, but won't fatal.

 It's 2015, so if any theme is using popup comments then I don't care
 enough about breaking it, but it would be good to know if there are any
 themes around which are using this functionality (any which are need to
 call the `comments_popup_script()` function, so that would be a good place
 to start if anyone wants to run a search).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28617#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform