[wp-trac] [WordPress Trac] #32866: dashicons CSS: one-word font families don't need quotes

[WordPress Trac]

#32866: dashicons CSS: one-word font families don't need quotes
------------------------------+-----------------------------
 Reporter:  afercia           |       Owner:  wonderboymusic
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  4.4
Component:  Administration    |     Version:  4.2
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:  ui
------------------------------+-----------------------------

Comment (by netweb):

 Replying to [comment:5 SergeyBiryukov]:
 > Should we perhaps add this to our
 [https://make.wordpress.org/core/handbook/best-practices/coding-
 standards/css/ CSS coding standards]?
 The "quote" part of this is already documented here:

 * https://make.wordpress.org/core/handbook/best-practices/coding-
 standards/css/#values
 * `Use double quotes rather than single quotes, and only when needed, such
 as when a font name has a space.`

 The "font name" part of this is also already documented and is now against
 what was just committed in r33912:
 * https://make.wordpress.org/core/handbook/best-practices/coding-
 standards/css/#properties
 * `All properties and values should be lowercase, except for font names
 and vendor-specific properties.`


 ----


 All Dashicon font file names are lowercase:
 https://core.trac.wordpress.org/browser/trunk/src/wp-includes/fonts

 `dashicons.svg` reports the font id as `<font id="dashicons" horiz-
 adv-x="2000" >`
 `dashicons.ttf` reports the name on Mac OSX Font Book as `Dashicons`
 The main GitHub repo https://github.com/melchoyce/dashicons uses
 `Dashicons` for font name.
 The commit message of r33912 uses `Dashicons` as the font name

 So the question is "Should this be reopened and all instances of the font
 name `dashicons` be replaced with `Dashicons`?" cc @helen @melchoyce

 ''This is an advantage/disadvantage of working on the CSS lint task in
 #29792 and ensuring there is no ambiguity ''

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32866#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform