[wp-trac] [WordPress Trac] #22249: Add ability to set or remove attributes on enqueued scripts and styles.

[WordPress Trac]

#22249: Add ability to set or remove attributes on enqueued scripts and styles.
-------------------------------------------------+-------------------------
 Reporter:  ryanve                               |       Owner:
     Type:  feature request                      |      Status:  new
 Priority:  normal                               |   Milestone:  Future
Component:  Script Loader                        |  Release
 Severity:  normal                               |     Version:
 Keywords:  has-patch needs-docs needs-unit-     |  Resolution:
  tests                                          |     Focuses:
-------------------------------------------------+-------------------------
Changes (by boonebgorges):

 * keywords:  dev-feedback has-patch reporter-feedback 2nd-opinion needs-
     testing => has-patch needs-docs needs-unit-tests


Comment:

 Yeah, let's move forward on this.

 Responding to [comment:17 alexye's most recent patch]:

 * The back compat trick for the `$in_footer` argument seems fine to me,
 though we need better docs for it. Here's the format for associative array
 param documentation: https://make.wordpress.org/core/handbook/best-
 practices/inline-documentation-standards/php/#1-1-parameters-that-are-
 arrays We also need a `@since` tag explaining this change.
 * It would be nice to see a copy of this that doesn't have unrelated
 whitespace/codestyling cleanup.
 * I'd feel more comfortable about the changes if we had some unit tests,
 especially surrounding the use of the repurposed `$in_footer` and `$media`
 params.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/22249#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform