[wp-trac] [WordPress Trac] #33361: "Edit Comment" metabox header styling is inconsistent with others

[WordPress Trac]

#33361: "Edit Comment" metabox header styling is inconsistent with others
-----------------------------+---------------------------------
 Reporter:  johnjamesjacoby  |       Owner:  rachelbaker
     Type:  defect (bug)     |      Status:  accepted
 Priority:  normal           |   Milestone:  4.4
Component:  Comments         |     Version:
 Severity:  minor            |  Resolution:
 Keywords:  has-patch        |     Focuses:  ui, administration
-----------------------------+---------------------------------

Comment (by afercia):

 In #31326 we started from the consideration that this box content is a
 group of logically related form fields, so we added a fieldset to group
 them and made "Author" a fieldset legend.

 I agree with Helen this looks like a "not-really-a-post-box" and probably
 the same CSS classes were used just to make it look like a post box. I
 don't see any reason to add a redundant heading that would just repeat
 "Author" or something similar and I would recommend to don't do that.
 Wondering if it really should be a post box in the first place :) Since
 it's not draggable, maybe it shouldn't look like a postbox.

 Please have a look at this screen with CSS turned off and notice how
 content gets read out by a screen reader (NVDA in this example):

 [[Image(https://cldup.com/UTg2Q3ahyJ.png)]]

 You will notice that semantics is not just an abstract concept but
 directly affects the way software gets and "understands" content. And thus
 affects people who use that software.

 The practical consequence of adding a fieldset with a legend is that NVDA
 announces this content block as "grouping". And then it also counts the
 form elements, announcing "1 of 3", "2 of 3" etc. All this would be lost
 without a fieldset + legend.

 I'm all for any CSS improvements :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33361#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform