[wp-trac] [WordPress Trac] #10377: Comment fields should have max lengths

WordPress Trac noreply at wordpress.org
Fri Sep 4 04:14:33 UTC 2015


#10377: Comment fields should have max lengths
------------------------------+--------------------------
 Reporter:  muriloazevedo     |       Owner:  rachelbaker
     Type:  defect (bug)      |      Status:  accepted
 Priority:  normal            |   Milestone:  4.4
Component:  Comments          |     Version:  2.8
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+--------------------------

Comment (by chriscct7):

 Replying to [comment:12 SergeyBiryukov]:
 > Instead of a hardcoded value, seems like we should use
 `$wpdb->get_col_length()` to get the actual value, in case someone
 modified the DB schema for a particular install.
 >
 > See [source:tags/4.3/src/wp-admin/includes/upgrade.php#L1531
 upgrade_430_fix_comments()] for reference.

 I don't know if that's worth the extra db call. Someone could just as
 easily use the filter to modify it if that's the case

--
Ticket URL: <https://core.trac.wordpress.org/ticket/10377#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list