[wp-trac] [WordPress Trac] #33657: wp.customize.Container.onChangeActive uses "construct" variable name instead of "container"
WordPress Trac
noreply at wordpress.org
Thu Sep 3 03:37:34 UTC 2015
#33657: wp.customize.Container.onChangeActive uses "construct" variable name
instead of "container"
-------------------------+------------------------------
Reporter: ericlewis | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Customize | Version: 4.3
Severity: normal | Resolution:
Keywords: has-patch | Focuses: javascript
-------------------------+------------------------------
Comment (by westonruter):
@ericlewis: There is a case against against using `this` or `self` (or
`that`), see #32911:
> `self` is a bad local variable name. Sometimes `self` is a substitute
for `this` when scope is lost in a maze of callbacks, but most of the
time, it just makes `this` more ambiguous than it already is.
/via @wonderboymusic
--
Ticket URL: <https://core.trac.wordpress.org/ticket/33657#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list