[wp-trac] [WordPress Trac] #33621: If FORCE_SSL_ADMIN is true, the scheme of the siteurl option should reflect this

[WordPress Trac]

#33621: If FORCE_SSL_ADMIN is true, the scheme of the siteurl option should reflect
this
--------------------------------------+------------------------------
 Reporter:  johnbillion               |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Administration            |     Version:  3.0
 Severity:  normal                    |  Resolution:
 Keywords:  needs-patch dev-feedback  |     Focuses:
--------------------------------------+------------------------------

Comment (by johnbillion):

 Replying to [comment:3 peterwilsoncc]:
 > I'm a little ambivalent on this, `siteurl` is a front end artefact and
 used by a number of resources as such.

 Can you provide some examples? If a resource is using `siteurl` (via
 `get_option('siteurl')` instead of `home_url()` or `site_url()`) then it's
 doing it wrong, and it's currently receiving a URL with an incorrect
 scheme anyway.

 > What is the advantage of overriding the setting in the DB rather than
 when `true === is_admin()`?

 The main reason I'm proposing this is that it's possible for a user to
 change the scheme of the `siteurl` option on the General Settings screen
 anyway. This means that for sites with `FORCE_SSL_ADMIN` set to true,
 there's disparity between those with a `siteurl` option that has an
 `https` scheme and those with an `http` scheme.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33621#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform