[wp-trac] [WordPress Trac] #34528: Responsive Images: Don't add srcset attributes to animated gifs.

[WordPress Trac]

#34528: Responsive Images: Don't add srcset attributes to animated gifs.
--------------------------------------+------------------------
 Reporter:  joemcgill                 |       Owner:  joemcgill
     Type:  defect (bug)              |      Status:  accepted
 Priority:  normal                    |   Milestone:  4.4
Component:  Media                     |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------

Comment (by joemcgill):

 Replying to [comment:2 DH-Shredder]:
 > I was chatting with @joehoyle about this.  Two things:
 >
 > - Since we're already flattening any resized image, this should only be
 a problem if the original size is being specifically chosen, correct?
 Maybe we can specifically target those, to make responsive images for for
 the other cases?

 Totally agree. My patch, [attachment:34528.diff] does specifically target
 cases where the original size is chosen.

 >
 > - PNGs can also be animated, so we need to address them as well, and I
 would hate to see them lose responsive support completely.  If we do the
 above, it should keep most of the support intact.

 Are a lot of people using animated PNGs? I worry about doing the same for
 PNGs because often times I see people inserting full size PNGs into their
 content that are essentially screenshots with very large file sizes. I'd
 hate to lose `srcset` support for these cases.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34528#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform