[wp-trac] [WordPress Trac] #33878: New function: `get_attachment_image_url()`

WordPress Trac noreply at wordpress.org
Sat Oct 31 20:39:39 UTC 2015


#33878: New function: `get_attachment_image_url()`
------------------------------+-----------------------------
 Reporter:  sebastian.pisula  |       Owner:  wonderboymusic
     Type:  enhancement       |      Status:  reopened
 Priority:  normal            |   Milestone:  4.4
Component:  Media             |     Version:
 Severity:  minor             |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+-----------------------------
Changes (by azaozz):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I'm sorry but why do we need this function?
 - It has confusing name: what's the difference between image_src and
 image_url? As far as I know these two are equivalent. We already had
 `wp_get_attachment_image_src()`, why do we need
 `wp_get_attachment_image_url()`?
 - It doesn't do anything. The only difference between
 `wp_get_attachment_image_src()` and `wp_get_attachment_image_url()` is
 that the former returns the image URL as an array value. Do we really need
 two functions that take exactly the same arguments and return exactly the
 same values just in a slightly different format? Looks like bloat?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33878#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list