[wp-trac] [WordPress Trac] #34523: Embeds: Make function parameters more clear

[WordPress Trac]

#34523: Embeds: Make function parameters more clear
--------------------------------------+-----------------------------
 Reporter:  swissspidy                |       Owner:  SergeyBiryukov
     Type:  defect (bug)              |      Status:  reviewing
 Priority:  normal                    |   Milestone:  4.4
Component:  Embeds                    |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 In [changeset:"35471"]:
 {{{
 #!CommitTicketReference repository="" revision="35471"
 Embeds: In `get_oembed_response_data()`, make the `$post` argument
 required.

 `get_oembed_response_data()` is called by the API endpoint controller and
 never in a context where it makes sense to use the global post object.

 Props swissspidy.
 See #34523.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34523#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform