[wp-trac] [WordPress Trac] #34523: Embeds: Make function parameters more clear

WordPress Trac noreply at wordpress.org
Sat Oct 31 13:25:53 UTC 2015


#34523: Embeds: Make function parameters more clear
--------------------------------------+--------------------
 Reporter:  swissspidy                |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  4.4
Component:  Embeds                    |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+--------------------

Comment (by swissspidy):

 `get_oembed_response_data()` is called by the API endpoint controller and
 never in a context where it makes sense to use the global post object.

 Therefore, [attachment:34523.2.diff] only changes the param order for
 `get_post_embed_html()` and does correctly so by not forgetting the embed
 template.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34523#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list