[wp-trac] [WordPress Trac] #34451: Embeds not working for non-WP sites

[WordPress Trac]

#34451: Embeds not working for non-WP sites
----------------------------------------------------+--------------------
 Reporter:  swissspidy                              |       Owner:
     Type:  defect (bug)                            |      Status:  new
 Priority:  normal                                  |   Milestone:  4.4
Component:  Embeds                                  |     Version:  trunk
 Severity:  major                                   |  Resolution:
 Keywords:  has-patch has-unit-tests needs-testing  |     Focuses:
----------------------------------------------------+--------------------
Changes (by swissspidy):

 * keywords:  has-patch has-unit-tests needs-refresh => has-patch has-unit-
     tests needs-testing


Comment:

 [attachment:34451.2.diff] is an updated patch with the improvements
 suggested above.

 * The `getSecret()` function in the iframe re-gets the secret when it was
 later on.
 * Change order in the IE checks.
 * Continue when `data-secret` attribute already exists.
 * Fixes #34462 by hiding/displaying the embed content during onLoad

 Note: The editor preview seems to be broken, but will be fixed by #34204

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34451#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform