[wp-trac] [WordPress Trac] #34492: #a11y-headings - Adapt title in Settings API to new hierarchy (was: Adapt title in Settings API to new hierarchy)

[WordPress Trac]

#34492: #a11y-headings - Adapt title in Settings API to new hierarchy
--------------------------------+--------------------------------
 Reporter:  neoxx               |       Owner:  afercia
     Type:  defect (bug)        |      Status:  assigned
 Priority:  normal              |   Milestone:  4.4
Component:  Options, Meta APIs  |     Version:  trunk
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:  ui, accessibility
--------------------------------+--------------------------------
Changes (by afercia):

 * focuses:  accessibility => ui, accessibility


Old description:

> Following https://make.wordpress.org/core/2015/10/28/headings-hierarchy-
> changes-in-the-admin-screens/ the title in ''do_settings_sections()''
> should move up one level, too.

New description:

 Following https://make.wordpress.org/core/2015/10/28/headings-hierarchy-
 changes-in-the-admin-screens/ the title in ''do_settings_sections()''
 should move up one level, too.

 #a11y-headings

--

Comment:

 @neoxx good catch, thanks very much :) Wondering what to do here, in some
 cases should be a `<h3>`:

 [[Image(https://cldup.com/32zicOgUD7.png)]]

 Without the "tabs", should be a `<h2>`. We've discussed a bit the "tabs",
 probably they shouldn't be within a heading in the first place and they're
 more a navigation sub-menu. I'd be inclined to keep things simple and just
 change the heading output by `do_settings_sections()` in a `<h2>`. As a
 side note, this is one of the reasons why I'm not so happy when core
 outputs some HTML assuming it's the proper markup in any case, without
 giving users the ability to filter it some way :)
 Will ask the accessibility team for some feedback, the proposed patch
 looks the best option to me.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34492#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform