[wp-trac] [WordPress Trac] #34456: Add add_theme_support('title-tag') to all default WordPress themes as wp_title() is deprecated since WordPress 4.4
WordPress Trac
noreply at wordpress.org
Thu Oct 29 11:56:29 UTC 2015
#34456: Add add_theme_support('title-tag') to all default WordPress themes as
wp_title() is deprecated since WordPress 4.4
-------------------------------------------------+-------------------------
Reporter: Nikschavan | Owner: obenland
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 4.4
Component: Bundled Theme | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch has-screenshots needs- | Focuses:
testing |
-------------------------------------------------+-------------------------
Changes (by obenland):
* keywords: has-patch dev-feedback has-screenshots needs-testing => has-
patch has-screenshots needs-testing
Comment:
Hi @Nikschavan, thanks for the ticket and the patch!
Some feedback:
The compat function would need an actual prefix and should be defined
outside of `twentythirteen_setup()`. We should also do a positive check
(`if ( function_exists() )` rather than `if ( ! function_exists() )`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34456#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list