[wp-trac] [WordPress Trac] #34204: Add fallbacks for WP oEmbed JavaScript & CSS

[WordPress Trac]

#34204: Add fallbacks for WP oEmbed JavaScript & CSS
-----------------------------------+--------------------------
 Reporter:  peterwilsoncc          |       Owner:  johnbillion
     Type:  defect (bug)           |      Status:  assigned
 Priority:  normal                 |   Milestone:  4.4
Component:  Embeds                 |     Version:  trunk
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:  javascript
-----------------------------------+--------------------------

Comment (by peterwilsoncc):

 Replying to [comment:30 helen]:
 > The short answer is no, don't keep them anywhere at all, but I'd like to
 know what those hacks are there for, exactly, please.

 The CSS fallbacks are less of an issue now the embed template in themes is
 blessed, refer #34278.

 The `lte ie8` CSS is there to provide a fallback for the SVG elements

 The `*` hacks are there to cover a number of issues:
 * IE7 does not support data-uris, using the * hack avoids the extra HTTP
 requests for IE8.
 * `display:table`, etc is not supported in IE7- so the site icon, site
 name and icons were stacked
 * without the * hacks, IE7 does not display the reference to comments in
 the `inline-block`

 I'm happy to discard the `*` hacks or to move them all to the IE file.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34204#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform