[wp-trac] [WordPress Trac] #34196: Add image size between Medium and Large to better take advantage of Responsive Image support
WordPress Trac
noreply at wordpress.org
Wed Oct 28 22:01:22 UTC 2015
#34196: Add image size between Medium and Large to better take advantage of
Responsive Image support
----------------------------------------+--------------------------
Reporter: DH-Shredder | Owner: DH-Shredder
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 4.4
Component: Media | Version:
Severity: normal | Resolution:
Keywords: needs-unit-tests has-patch | Focuses:
----------------------------------------+--------------------------
Comment (by joemcgill):
[attachment:34196.patch] Is a refresh of
[attachment:working_bad_tests.diff] that fixes the failing tests. It may
be wise to split the test for inserting the new size into its own test
instead of adding it to
`Tests_Post_Attachments:test_insert_image_medium_sizes`. There are already
too many assertions happening in that one test IMO.
Also, to make sure the new image size got created for the test, I had to
update the value of the `medium_large_size_w` option so the width would be
smaller than the original image, otherwise the intermediate size was
getting skipped.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34196#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list