[wp-trac] [WordPress Trac] #34204: Add fallbacks for WP oEmbed JavaScript & CSS
WordPress Trac
noreply at wordpress.org
Wed Oct 28 08:38:36 UTC 2015
#34204: Add fallbacks for WP oEmbed JavaScript & CSS
-----------------------------------+--------------------------
Reporter: peterwilsoncc | Owner: johnbillion
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.4
Component: Embeds | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion | Focuses: javascript
-----------------------------------+--------------------------
Comment (by swissspidy):
Replying to [comment:27 pento]:
> [attachment:34204.6.diff] updates the patch to apply cleanly against
trunk.
>
> I'm not particularly excited about the `*` IE7 hack being in `wp-embed-
template.css`, I think browser hacks should really be kept to
conditionally loaded files.
Note: In that patch the `*` hack is now in both CSS files. Moving it to
`wp-embed-template-ie.css` makes sense, if that hack is really needed.
`wp-includes/dashicons.css` doesn't have these hacks in it.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34204#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list