[wp-trac] [WordPress Trac] #34429: Slack embeds look super ugly

WordPress Trac noreply at wordpress.org
Mon Oct 26 23:54:07 UTC 2015


#34429: Slack embeds look super ugly
------------------------------+---------------------
 Reporter:  pento             |       Owner:  pento
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  4.4
Component:  Embeds            |     Version:  trunk
 Severity:  blocker           |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:
------------------------------+---------------------
Changes (by pento):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"35406"]:
 {{{
 #!CommitTicketReference repository="" revision="35406"
 Embeds: Add a CDATA and HTML comment wrapper around the JavaScript
 included in the embed HTML. This ensures that user agents which naively
 strip unwanted tags, without also stripping the content within those tages
 (for example, Slack), don't show the embed as a mess of JavaScript.

 Props peterwilsoncc.

 Fixes #34429.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34429#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list