[wp-trac] [WordPress Trac] #34429: Slack embeds look super ugly
WordPress Trac
noreply at wordpress.org
Mon Oct 26 07:14:10 UTC 2015
#34429: Slack embeds look super ugly
--------------------------+--------------------
Reporter: pento | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 4.4
Component: Embeds | Version: trunk
Severity: blocker | Resolution:
Keywords: needs-patch | Focuses:
--------------------------+--------------------
Comment (by swissspidy):
Replying to [comment:9 pento]:
> Replying to [comment:7 danielbachhuber]:
> > Can we serve a no-script fallback in the beginning of the response as
Twitter does? Then, the JavaScript would remove the fallback
>
> Yep, that was on the todo list somewhere - @helen suggested it a while
ago. I'm not sure why it wasn't done before merge - @swissspidy, what
happened to this?
Can't find a discussion on Slack right now, but there were two GitHub
issues about this:
https://github.com/swissspidy/oEmbed-API/issues/138
https://github.com/swissspidy/oEmbed-API/pull/158
The problem was that Slack uses the content from every element, so if you
have some JS to remove the `<noscript>` fallback, the content of both
elements would show. And if you use external JS to remove the
`<noscript>`, how do you ensure that it only creates a sandboxed
`<iframe>`?
Note: Using CDATA might be a solution, see
https://wordpress.slack.com/archives/core/p1445828420002520
Still waiting for an answer from Slack.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34429#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list