[wp-trac] [WordPress Trac] #34403: Errors during smooth updates not displayed

[WordPress Trac]

#34403: Errors during smooth updates not displayed
-----------------------------+-----------------------------
 Reporter:  mordauk          |      Owner:
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Upgrade/Install  |    Version:  trunk
 Severity:  normal           |   Keywords:
  Focuses:  administration   |
-----------------------------+-----------------------------
 When a smooth update (introduced in #29820) fails to complete, an error is
 supposed to be displayed. This, however, does not appear to be the case
 anymore. Update errors fail to display in trunk and also 4.3.1. It could
 be be happening in other versions as well but I have not confirmed it.

 Instead of displaying a visual error, the updating indicator just spins
 forever.
 [[Image(https://cldup.com/x0lfBuK9kq-3000x3000.png)]]

 I have confirmed this on a local test site and also on a live site running
 4.3.1.

 This can be easily tested by forcibly returning a `WP_Error` at the top of
 `download_package()` in `WP_Upgrader`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34403>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform