[wp-trac] [WordPress Trac] #34379: Responsive Images: Streamline wp_get_attachment_image_sizes()

[WordPress Trac]

#34379: Responsive Images: Streamline wp_get_attachment_image_sizes()
------------------------------+--------------------------
 Reporter:  joemcgill         |       Owner:  joemcgill
     Type:  defect (bug)      |      Status:  reopened
 Priority:  normal            |   Milestone:  4.4
Component:  Media             |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  performance
------------------------------+--------------------------
Changes (by jorbin):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I really don't like the idea of changing the wp_get_attachment_image_sizes
 function signature.  If we need to go from accepting an array to accepting
 an integer, we should either:

 1) Create a new function and deprecated wp_get_attachment_image_sizes
 2) Ensure that passing an array doesn't change the behavior of
 wp_get_attachment_image_sizes through automated tests.

 Backwards incompatible changes like this make it harder for users to
 upgrade and break sites and plugins when they do upgrade.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34379#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform