[wp-trac] [WordPress Trac] #34206: Add a Favorites Tab to the Add New Themes Page

[WordPress Trac]

#34206: Add a Favorites Tab to the Add New Themes Page
------------------------------------+-----------------------------
 Reporter:  jeffr0                  |       Owner:  SergeyBiryukov
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  4.4
Component:  Themes                  |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  ui
------------------------------------+-----------------------------
Changes (by swissspidy):

 * keywords:  has-patch => has-patch dev-feedback


Comment:

 [attachment:34206.2.diff] is a new patch that adds the username form as
 well.

 Data is submitted via GET, just like on the plugin install screen. Because
 of that I needed to add a `sort.split('&')[0]` line to the sort method.
 Otherwise it would try to sort themes after `favorites&user=<user>`.
 Haven't found the proper way in the router to change that. It's not a big
 deal, but maybe someone wants to make this more beautiful.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34206#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform