[wp-trac] [WordPress Trac] #21949: Allow private taxonomies (public = false)

[WordPress Trac]

#21949: Allow private taxonomies (public = false)
--------------------------------+---------------------------
 Reporter:  wpsmith             |       Owner:  boonebgorges
     Type:  enhancement         |      Status:  closed
 Priority:  normal              |   Milestone:  4.4
Component:  Taxonomy            |     Version:
 Severity:  normal              |  Resolution:  fixed
 Keywords:  has-patch rest-api  |     Focuses:
--------------------------------+---------------------------
Changes (by boonebgorges):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"35333"]:
 {{{
 #!CommitTicketReference repository="" revision="35333"
 Prevent non-public taxonomies from registering  aquery var.

 [34247] made the 'public' paramater of `register_taxonomy()` work by
 blocking
 requests for non-public taxonomy archives during `parse_request()`.
 Blocking
 taxonomy archive requests this late means that it's impossible to register
 an
 independent query var that matches the slug of a non-public taxonomy. By
 moving the block to `register_taxonomy()` - not allowing these taxonomies
 to
 register their query vars in the first place - we free up the slug for
 other
 use. In addition, we free up a bit of processing (no need to look for the
 query
 var in `parse_request()` and better parallel the way non-public post types
 work. See `register_post_type()`.

 Non-public taxonomy archives that are requested using `?taxonomy=tax_name`
 are
 still blocked during `parse_request`. It's only custom query vars -
 `?tax_name=term` - that are affected by this change.

 Props mboynes.
 Fixes #21949.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21949#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform