[wp-trac] [WordPress Trac] #8071: Refrain from querying all the comments on a post when paged

[WordPress Trac]

#8071: Refrain from querying all the comments on a post when paged
------------------------------------+---------------------------
 Reporter:  markjaquith             |       Owner:  boonebgorges
     Type:  task (blessed)          |      Status:  reopened
 Priority:  normal                  |   Milestone:  4.4
Component:  Comments                |     Version:  2.7
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |     Focuses:
------------------------------------+---------------------------

Comment (by boonebgorges):

 In [changeset:"35331"]:
 {{{
 #!CommitTicketReference repository="" revision="35331"
 Don't force comment pagination.

 [34561] instituted the policy of forcing pagination for comments. This
 strategy
 was intended to avert problems when 'page_comments' is set to 0 - as it is
 by
 default - and the number of comments on a given post rises into the
 hundreds or
 thousands. By forcing pagination in all cases, we ensured that WordPress
 would
 not time out by processing unwieldy numbers of comments on a given
 pageload.

 The strategy proves problematic, however, because comment permalinks are
 generated using the page of the comment. Forcing pagination for posts that
 were not previously paginated would change the URL of all comments that do
 not
 appear on the default comment page.

 This changeset reintroduces the 'page_comments' setting and its
 corresponding
 checkbox on Settings > Discussion. A number of tests, which were written
 after
 [34561], are modified to work now that 'page_comments' will, once again,
 be
 disabled by default.

 See #8071.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/8071#comment:62>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform