[wp-trac] [WordPress Trac] #22405: Easier expression of file sizes and other data amounts

[WordPress Trac]

#22405: Easier expression of file sizes and other data amounts
-------------------------+---------------------------
 Reporter:  nbachiyski   |       Owner:  DrewAPicture
     Type:  enhancement  |      Status:  accepted
 Priority:  normal       |   Milestone:  4.4
Component:  General      |     Version:  3.5
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+---------------------------

Comment (by DrewAPicture):

 Replying to [comment:20 sudar]:
 > In addition to the ones that I changed in the above patch I also found a
 couple of instances inside `wp-includes/ID3/*.php` and `wp-admin/includes
 /class-pclzip.php`.
 >
 > Since these were external libraries I didn't change them to use the
 *_IN_BYTES constants. Let me know If the hard coded numbers should be
 replaced with the constants even in these external libraries.

 Nope, you did right to leave them alone I think. If others disagree, we
 can always come back and do those replacements later. Thanks for the
 patch.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/22405#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform