[wp-trac] [WordPress Trac] #34376: Review the FTP credentials form

[WordPress Trac]

#34376: Review the FTP credentials form
-------------------------------------------+-----------------------------
 Reporter:  afercia                        |      Owner:
     Type:  defect (bug)                   |     Status:  new
 Priority:  normal                         |  Milestone:  Awaiting Review
Component:  Administration                 |    Version:  4.2
 Severity:  normal                         |   Keywords:
  Focuses:  ui, accessibility, javascript  |
-------------------------------------------+-----------------------------
 Note: to make the FTP credentials form appear and test it I'm using the
 [https://wordpress.org/plugins/core-control/ Core Control plugin].

 In the FTP credentials form there's still some inline JavaScript to toggle
 the visibility of an element with ID "ssh_keys". That element was a table
 row for the SSH authentication keys and the table was removed in [31949].
 The SSH fields are still there, but not inside a table.

 Checking how it worked in WordPress 4.0, the SSH fields were initially
 hidden with some inline CSS if `'ssh' != $connection_type` and then the
 visibility toggled when clicking the FTP or FTPS radio buttons:

 [[Image(https://cldup.com/Pdi5p9wBiU.png)]]

 [[Image(https://cldup.com/VYV5bh6oHK.png)]]

 I think the outdated part of the inline JavaScript should be tweaked or
 better removed in favor of what's in `updates.js` that currently works
 only in the modal.

 I'd recommend also to move the "Connection type" radio buttons above all
 the other fields: for accessibility the revealed elements should be
 '''after''' the control that revealed them.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34376>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform