[wp-trac] [WordPress Trac] #34368: WP_Site_Icon->get_post_metadata performance improvement

[WordPress Trac]

#34368: WP_Site_Icon->get_post_metadata performance improvement
---------------------------------------------+--------------------------
 Reporter:  ap.koponen                       |       Owner:  obenland
     Type:  enhancement                      |      Status:  assigned
 Priority:  normal                           |   Milestone:  4.4
Component:  Administration                   |     Version:  trunk
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch commit has-unit-tests  |     Focuses:  performance
---------------------------------------------+--------------------------
Changes (by swissspidy):

 * keywords:  has-patch commit => has-patch commit has-unit-tests


Comment:

 Replying to [comment:3 ocean90]:
 > Replying to [comment:2 swissspidy]:
 > > [attachment:34368.diff] uses strict comparison
 >
 > Be careful with strict comparison:
 > {{{#!php
 > <?php
 > var_dump( get_option( 'site_icon' ) ); // string(4) "1785"
 > }}}

 That wasn't a problem in the unit test (see [attachment:34368.2.diff]),
 but I added an `(int)` nonetheless.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34368#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform