[wp-trac] [WordPress Trac] #31767: insert_with_markers() is not atomic, leading to corrupted .htaccess updates under race conditions

[WordPress Trac]

#31767: insert_with_markers() is not atomic, leading to corrupted .htaccess updates
under race conditions
-----------------------------------+-----------------------
 Reporter:  tigertech              |       Owner:  dd32
     Type:  defect (bug)           |      Status:  assigned
 Priority:  normal                 |   Milestone:  4.4
Component:  Filesystem API         |     Version:  4.1.1
 Severity:  critical               |  Resolution:
 Keywords:  4.4-early needs-patch  |     Focuses:
-----------------------------------+-----------------------

Comment (by tigertech):

 I've tested this latest change and it appears to work fine. Thanks!

 > Personally I'm thinking of leaving it as-is and blocking and waiting,
 because if you're writing on every pageload you're doing bad things.

 I agree; it's more correct. The "two different things are writing two
 different markers" is actually a likely occurrence -- the data loss I've
 seen usually happens when two different mistaken "write on every page
 view" plugins/themes run simultaneously.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31767#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform