[wp-trac] [WordPress Trac] #9134: cannot remove the link to comments in feeds

[WordPress Trac]

#9134: cannot remove the link to comments in feeds
-------------------------------------------------+-------------------------
 Reporter:  jidanni                              |       Owner:
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.4
Component:  Feeds                                |     Version:  2.7
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch has-unit-   |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------
Changes (by swissspidy):

 * keywords:  needs-docs good-first-bug has-patch => good-first-bug has-
     patch has-unit-tests
 * milestone:  Future Release => 4.4


Comment:

 IMHO adding a new `has_comments_link` function that is only used for feeds
 isn't really needed. All default themes and the new embed template in 4.4
 use an `if ( get_comments_number() || comments_open() ) {}` check to show
 comment links.

 `comments_open()` is already filterable, so it's easy to hide comment info
 from feeds when `comments_open()` returns `false` and there are no
 comments on a post.

 [attachment:9134.2.diff] does exactly that.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/9134#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform