[wp-trac] [WordPress Trac] #34339: Default option for site_icon

WordPress Trac noreply at wordpress.org
Sat Oct 17 12:19:01 UTC 2015


#34339: Default option for site_icon
--------------------------------+------------------------------
 Reporter:  sebastian.pisula    |       Owner:
     Type:  enhancement         |      Status:  new
 Priority:  normal              |   Milestone:  Awaiting Review
Component:  Options, Meta APIs  |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  reporter-feedback   |     Focuses:
--------------------------------+------------------------------
Changes (by swissspidy):

 * keywords:   => reporter-feedback


Comment:

 Can you explain why this should be needed? `update_blog_option` would
 result in an additional, unneeded database query just so that there's a
 `0`.

 If you want a different default value, we could pass that as the second
 argument to `get_option`.

 Also, why is `SELECT option_value FROM wp_options WHERE option_name =
 'site_icon' LIMIT 1` unnecessary? I mean, somehow we need to get that
 option from the database…

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34339#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list