[wp-trac] [WordPress Trac] #31403: Hardcoded Id in WP 4.1.1 Wpeditimage

WordPress Trac noreply at wordpress.org
Sat Oct 17 04:15:11 UTC 2015


#31403: Hardcoded Id in WP 4.1.1 Wpeditimage
--------------------------+-----------------------------
 Reporter:  programmin    |       Owner:
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  4.3
Component:  TinyMCE       |     Version:  4.1
 Severity:  normal        |  Resolution:  fixed
 Keywords:  needs-patch   |     Focuses:  ui, javascript
--------------------------+-----------------------------

Comment (by programmin):

 I don't think so. See wp-includes/js/tinymce/plugins/wordpress/plugin.js:



 {{{
 var Factory = tinymce.ui.Factory,
                         settings = editor.settings,
                         activeToolbar,
                         currentSelection,
                         timeout,
                         container = editor.getContainer(),
                         wpAdminbar = document.getElementById( 'wpadminbar'
 ),
                         mceIframe = document.getElementById( editor.id +
 '_ifr' ),
                         mceToolbar,
                         mceStatusbar,
                         wpStatusbar;
 }}}

 So still referencing an (id)_ifr and expecting it to be an iframe (not
 inline-mode-friendly), and also expecting a #wpAdminbar element (what if
 you want to use the plugin in an editor that's not on /wp-admin/ page??)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/31403#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list