[wp-trac] [WordPress Trac] #33327: Customize: Make Widgets reorder button a button
WordPress Trac
noreply at wordpress.org
Fri Oct 16 22:19:15 UTC 2015
#33327: Customize: Make Widgets reorder button a button
--------------------------+--------------------------------------------
Reporter: obenland | Owner: afercia
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.4
Component: Customize | Version: 4.3
Severity: normal | Resolution:
Keywords: has-patch | Focuses: ui, accessibility, javascript
--------------------------+--------------------------------------------
Comment (by ocean90):
[attachment:33327.2.diff]
* `str_replace()` accepts arrays too: `str_replace( array('[', ']' ),
array( '-', '' ), $this->id );`
* `esc_attr__( 'Reorder' ), ` should get a context, probably the same as
`<?php _ex( 'Reorder', 'Reorder widgets in Customizer' ); ?>`
Otherwise this looks good, `grunt precommit` and unit tests are passing.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/33327#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list