[wp-trac] [WordPress Trac] #34323: Make customizer media control placeholders clickable

WordPress Trac noreply at wordpress.org
Fri Oct 16 12:46:26 UTC 2015


#34323: Make customizer media control placeholders clickable
-------------------------------------+--------------------------------
 Reporter:  NateWr                   |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Customize                |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, accessibility
-------------------------------------+--------------------------------
Changes (by afercia):

 * focuses:  ui => ui, accessibility


Comment:

 I'd recommend every new UI control should be introduced with a basic level
 of accessibility. Currently, this "clickable div" is not even focusable
 with a keyboard. Every UI control should be operable using just the
 keyboard. And it's just a div, doesn't convey any semantics at all.

 Additionally, there are a lot of clickable things here :) Maybe too many:
 - click on the label and the modal opens
 - click on the description (which is inside the label and there's a ticket
 for that) and the modal opens
 - click on the placeholder and the modal opens
 - click on the button and the modal opens

 [[Image(https://cldup.com/M5DWNTfOua.png)]]

 I'm not even sure there's the need for a new control in the first place.
 If now the placeholder is clickable, what's the purpose of the "Select
 Image" button?

 Maybe we should consider to remove things instead, not add new (redundant)
 ones.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34323#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list