[wp-trac] [WordPress Trac] #34249: Some issues with _doing_it_wrong()

[WordPress Trac]

#34249: Some issues with _doing_it_wrong()
-------------------------------------+--------------------
 Reporter:  pavelevap                |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.4
Component:  I18N                     |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:
-------------------------------------+--------------------
Changes (by swissspidy):

 * keywords:   => has-patch needs-refresh
 * milestone:  Awaiting Review => 4.4


Comment:

 +1 for adding fullstops and removing spaces.

 +1 for changing `WPAPI-2.0` to `4.4.0`. Perhaps in a separate ticket
 though. (ping @rmccue)

 -1 to changing `__FUNCTION__` to `'add_shortcode'`

 Note: The `_doing_it_wrong` for the shortcode was added in [32867] (see
 #32445).

 +1 for adding a translator comment to that message you mentioned. In that
 message, `%s` refers to the database access abstraction class (usually
 `wpdb` or a class extending `wpdb`).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34249#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform