[wp-trac] [WordPress Trac] #32417: Add new core widget: image widget
WordPress Trac
noreply at wordpress.org
Thu Oct 15 20:46:28 UTC 2015
#32417: Add new core widget: image widget
----------------------------------------+---------------------------------
Reporter: melchoyce | Owner: wonderboymusic
Type: feature request | Status: assigned
Priority: normal | Milestone: 4.4
Component: Widgets | Version: 4.3
Severity: normal | Resolution:
Keywords: needs-unit-tests has-patch | Focuses: ui, administration
----------------------------------------+---------------------------------
Comment (by DrewAPicture):
Replying to [comment:52 Fab1en]:
> In [attachment:32417.4.patch], I fixed the JS errors and make the widget
actually display an audio or a video player on the front when such media
is selected (previously, only the preview was working).
>
> Here are the issues I see so far:
> 1. If you select a video, and then click again on "Select media" and
choose an image, both image and video appear on the preview. Saving the
widget solves the issue.
Probably just need to flush out the container before insert.
> 1. Captions does not work (do we really need it here ?).
If people are inserting images then we're going to need caption support,
yes.
> 1. Galleries and playlists do not work. We perhaps do not need to make
it work here (its a "single media" widget), but we should at least remove
the "Create Gallery" and "Create Playlist" menus in the media modal.
I would expect to be able to insert a gallery or a playlist as a "media
item", so I'm not sure doing away with the expected options is an
improvement. If it "does not work" then maybe we need to look at making it
work. Can you be more specific?
> 1. Change "Insert into Post" button text in the media modal to something
more meaningful
"Use as Widgets" isn't great either. I think a simple "Insert Media" would
suffice.
> 1. In the admin preview, a click on the image displays the media modal,
which is OK. But this behavior only works the first time.
Might just need to refresh a nonce.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/32417#comment:54>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list