[wp-trac] [WordPress Trac] #34312: On Multisite has_site_icon( $child_blog_id ) when checking from the root blog is false even if the child blog has a site icon

[WordPress Trac]

#34312: On Multisite has_site_icon( $child_blog_id ) when checking  from the root
blog is false even if the child blog has a site icon
------------------------------------+------------------------------
 Reporter:  imath                   |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Networks and Sites      |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  multisite
------------------------------------+------------------------------

Comment (by BinaryKitten):

 hi @imath,

 unfortunately the patch rendering squelched it originally so thanks for
 the link (that was equiv to snippet I needed).


 seeing the context, it seems like this could be a good fix.

 For the unit test, can you add some more assertions so the flow is:
 createblog, has_site_icon on blog == false, switch to blog, has_site_icon
 == false, set site icon, has_site_icon == true, restore current blog,
 has_site_icon on blog == true

 thnx

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34312#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform