[wp-trac] [WordPress Trac] #34312: On Multisite has_site_icon( $child_blog_id ) when checking from the root blog is false even if the child blog has a site icon

[WordPress Trac]

#34312: On Multisite has_site_icon( $child_blog_id ) when checking  from the root
blog is false even if the child blog has a site icon
------------------------------------+------------------------------
 Reporter:  imath                   |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Networks and Sites      |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  multisite
------------------------------------+------------------------------
Changes (by BinaryKitten):

 * keywords:  has-patch => has-patch dev-feedback


Comment:

 Hi @imath - looking at the code for get_blog_option, that function should
 be using switch_to_blog before and restore_current_blog after the
 get_option function call.

 I'm hesitant to introduce more code to the get_site_icon call, especially
 when the patch adds the same functionality as the function call it's
 replacing, though i'm by no means the arbiter of the fate.

 pinging @jeremyfelt for their thoughts..

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34312#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform