[wp-trac] [WordPress Trac] #34274: _oembed_create_xml() uses SimpleXML, which can be disabled

WordPress Trac noreply at wordpress.org
Thu Oct 15 07:56:25 UTC 2015


#34274: _oembed_create_xml() uses SimpleXML, which can be disabled
--------------------------+--------------------
 Reporter:  johnbillion   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  4.4
Component:  Embeds        |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+--------------------

Comment (by rmccue):

 We build XML via string manipulation in a lot of places (urgh), so that's
 an option, albeit a sucky one. If we do that, we need to be extremely
 careful about sanitisation, and not producing invalid UTF-8.

 I'd prefer not to; I think we could probably get away with a 501, since
 I'd expect lots of people are using JSON anyway. It's optional per the
 oEmbed spec anyway. (We could probably remove all of the XML handling if
 we really wanted; @swissspidy would know more about compatibility though.)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34274#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list