[wp-trac] [WordPress Trac] #33055: Support Parallel HTTP Requests in WP_Http, et al
WordPress Trac
noreply at wordpress.org
Thu Oct 15 06:01:51 UTC 2015
#33055: Support Parallel HTTP Requests in WP_Http, et al
----------------------------+-----------------------
Reporter: wonderboymusic | Owner: rmccue
Type: task (blessed) | Status: assigned
Priority: normal | Milestone: 4.4
Component: HTTP API | Version:
Severity: normal | Resolution:
Keywords: needs-patch | Focuses:
----------------------------+-----------------------
Comment (by rmccue):
I've been working on making this happen. Requests has now been updated to
add the few things it was missing that WP_Http has (byte limiting being
the main one), and I've fixed a few other bugs.
Running [https://github.com/rmccue/Requests-WPHTTP Requests-WPHTTP] now
only causes one test failure, which is due to 302 redirects: WP_Http
follows browser behaviour, in which a 302 redirect changes POST to GET;
Requests follows the spec behaviour, which is to keep the same method
unless otherwise stated. (The spec states that 302 handling MAY change the
method, but only for browser compat.)
I talked to @dd32 about this, and I think we're both happy with leaving it
and changing the WP test instead; WP_Http isn't a browser, so it doesn't
need to emulate one.
Code coverage is at
[https://codecov.io/github/rmccue/Requests?branch=master 87%]; I'm
planning to get this up a bit further, but it beats WP_Http hands down in
that regard.
If we're happy, I'll whip up a patch and we can keep this moving.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/33055#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list