[wp-trac] [WordPress Trac] #34295: "Apply" button for screen options isn't just for the per-page setting

[WordPress Trac]

#34295: "Apply" button for screen options isn't just for the per-page setting
---------------------------------------+---------------------
 Reporter:  helen                      |       Owner:  helen
     Type:  enhancement                |      Status:  closed
 Priority:  normal                     |   Milestone:  4.4
Component:  Administration             |     Version:
 Severity:  normal                     |  Resolution:  fixed
 Keywords:  has-patch has-screenshots  |     Focuses:  ui
---------------------------------------+---------------------
Changes (by helen):

 * owner:   => helen
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"35161"]:
 {{{
 #!CommitTicketReference repository="" revision="35161"
 Screen options: Improve the "Apply" button

 Previously the button was output as a part of the per-page option
 rendering, inline with that input. While this was appropriate for core's
 usage, the `screen_settings` filter has allowed plugins to place
 additional items at the bottom of the panel, which a number take advantage
 of. This leads to confusing situations where plugins that don't save
 settings via Ajax either have to add their own button or piggyback onto
 the existing button, which doesn't make any sense in the flow of
 additional options. It also hinders core from adding any other options
 that need to be submitted.

 Also, when the screen options panel is open, a submit button there is the
 primary action at that moment. The "Apply" button also does a full page
 load, which a primary button indicates better.

 fixes #34295. see #22222, #23738.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34295#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform