[wp-trac] [WordPress Trac] #23738: Audit our secondary button uses
WordPress Trac
noreply at wordpress.org
Wed Oct 14 18:57:19 UTC 2015
#23738: Audit our secondary button uses
-------------------------------------------------+-------------------------
Reporter: markjaquith | Owner:
Type: enhancement | markjaquith
Priority: normal | Status: assigned
Component: Administration | Milestone: 4.4
Severity: normal | Version: 3.6
Keywords: good-first-bug has-patch needs- | Resolution:
testing | Focuses: ui
-------------------------------------------------+-------------------------
Comment (by helen):
In [changeset:"35161"]:
{{{
#!CommitTicketReference repository="" revision="35161"
Screen options: Improve the "Apply" button
Previously the button was output as a part of the per-page option
rendering, inline with that input. While this was appropriate for core's
usage, the `screen_settings` filter has allowed plugins to place
additional items at the bottom of the panel, which a number take advantage
of. This leads to confusing situations where plugins that don't save
settings via Ajax either have to add their own button or piggyback onto
the existing button, which doesn't make any sense in the flow of
additional options. It also hinders core from adding any other options
that need to be submitted.
Also, when the screen options panel is open, a submit button there is the
primary action at that moment. The "Apply" button also does a full page
load, which a primary button indicates better.
fixes #34295. see #22222, #23738.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/23738#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list