[wp-trac] [WordPress Trac] #33999: WordPress Update issue

[WordPress Trac]

#33999: WordPress Update issue
-----------------------------+-----------------------------
 Reporter:  MrZen88          |       Owner:  SergeyBiryukov
     Type:  defect (bug)     |      Status:  accepted
 Priority:  normal           |   Milestone:  4.4
Component:  Upgrade/Install  |     Version:  4.3.1
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+-----------------------------

Comment (by dd32):

 Replying to [comment:6 MrZen88]:
 > The problem occur when you update via FTP on the website. When you read
 the code, it don't check a real path but a relative path. And it look like
 that we need to specify the DIRECTORY_SEPARATOR. It always a good practice
 tu use DIRECTORY_SEPARATOR when you specify a path if you want your code
 to work on Windows and linux. Because linux understand a slash ('/') and
 windows understand a backslash ('\') as directory separator. The code just
 refer to a relative path who want to be to the root of your site.
 >
 > Try it, install filezilla server on windows and make an automatique
 update from the website via FTP and you will see in the filezilla log that
 he can reach the root of the site. It work only with DIRECTORY_SEPARATOR.

 FWIW, FTP implementations all unix-style path separators, regardless of
 the operating system. Using `DIRECTORY_SEPERATOR` would actually break in
 that scenario.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/33999#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform