[wp-trac] [WordPress Trac] #17630: Redirect wp-signup.php to wp_signup_location
WordPress Trac
noreply at wordpress.org
Sun Oct 11 22:00:33 UTC 2015
#17630: Redirect wp-signup.php to wp_signup_location
--------------------------------------+-------------------------
Reporter: dwieeb | Owner: jeremyfelt
Type: enhancement | Status: reviewing
Priority: normal | Milestone: 4.4
Component: Login and Registration | Version: 3.1.3
Severity: normal | Resolution:
Keywords: good-first-bug has-patch | Focuses: multisite
--------------------------------------+-------------------------
Comment (by jeremyfelt):
Replying to [comment:18 sujin2f]:
> @jeremyfelt I don't understand why did you want to set an action because
there is wp_signup_location filter already. If we make a new action,
people will have to set one filter and one action in order to change the
signup location. Just for preventing redirection loop?
Correct. Someone would probably have the easiest time redirecting `wp-
signup.php` manually at the server level, but for those needing to force
it via plugin, a second action to short-circuit the file should be fine.
Reliance on the current `wp_signup_location` filter is a bit iffy, mostly
because we would need to compare it with `network_site_url( 'wp-
signup.php' )` which could also be filtered. We could make an attempt at
comparing it with `$_SERVER['SCRIPT_NAME']`, but I'm not sure how reliable
that would be.
The use of a new action allows for a general short-circuit of the `wp-
signup.php` load and would also help anyone trying to replace the signup
experience without changing the location. It also aligns us a bit more
with what actions are available in `wp-activate.php`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/17630#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list