[wp-trac] [WordPress Trac] #27317: Update wp_insert_user function to return 'pre_user_login' filter WP_Errors

WordPress Trac noreply at wordpress.org
Sun Oct 11 17:37:12 UTC 2015


#27317: Update wp_insert_user function to return 'pre_user_login' filter WP_Errors
-------------------------------------------------+-------------------------
 Reporter:  crazycoolcam                         |       Owner:  chriscct7
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.4
Component:  Users                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch dev-feedback needs-        |     Focuses:
  refresh needs-docs                             |
-------------------------------------------------+-------------------------
Changes (by DrewAPicture):

 * keywords:  has-patch dev-feedback => has-patch dev-feedback needs-refresh
     needs-docs


Comment:

 @chriscct7 Some notes on [attachment:27317.5.patch]:

 * Patch needs a refresh
 * The summary for the `illegal_user_logins` filter should describe
 ''what'' is filterable, rather than what it allows. And it should end with
 a period
 * For the parameter, we should use a "fake" variable, maybe `$usernames`,
 instead of `array()`, and the parameter description should mention the
 default value and end with a period
 * Subsequent duplicates of `illegal_user_logins` should have a single-line
 comment written in the following style:
 {{{
 /** This filter is documented in wp-admin/includes/user.php */
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27317#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list