[wp-trac] [WordPress Trac] #22222: "Mode" buttons bumped below (in 1024x768) when long category name exists
WordPress Trac
noreply at wordpress.org
Sat Oct 10 16:26:02 UTC 2015
#22222: "Mode" buttons bumped below (in 1024x768) when long category name exists
-------------------------------------+-------------------------------------
Reporter: trepmal | Owner: Oxymoron
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.4
Component: Posts, Post Types | Version:
Severity: minor | Resolution:
Keywords: good-first-bug needs- | Focuses: ui, accessibility,
refresh | administration
-------------------------------------+-------------------------------------
Changes (by afercia):
* keywords: good-first-bug has-patch => good-first-bug needs-refresh
Comment:
Sorry for asking for a new patch refresh :) After [34991] and [35010] we
should avoid using a `<h5>` and use a fieldset + legend instead. Also, for
consistency and cleaner code, this should be moved out of
`render_screen_options()` and be in its own "render" method.
Discussed this a bit with @helen and we should make sure the "Apply"
button is always displayed at the bottom as last thing. The button should
also be a "primary" button. Plugins can add their own settings and we
can't predict if they will add their own "Apply" button or not.
In the screenshot below, see an example of additional settings appended by
plugins and on the right how it would look like moving the button at the
bottom.
[[Image(https://cldup.com/Oaa7b-skRV.png)]]
Also, we've noticed the Apply button submits the whole form, also the
"live" settings will be re-submitted. Not sure what to do here.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/22222#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list