[wp-trac] [WordPress Trac] #34242: Buttons styles: audit the button-reset and button-link styles

[WordPress Trac]

#34242: Buttons styles: audit the button-reset and button-link styles
----------------------------+-----------------------------
 Reporter:  afercia         |      Owner:
     Type:  defect (bug)    |     Status:  new
 Priority:  normal          |  Milestone:  Awaiting Review
Component:  Administration  |    Version:  4.3
 Severity:  normal          |   Keywords:
  Focuses:  ui              |
----------------------------+-----------------------------
 With recent developments, for example the new Press This and some new
 features in the Customizer, some new buttons CSS classes were introduced
 in core. They basically serve the same two purposes:
 - a general "reset" class for the buttons background, margin, padding,
 etc.
 - a class to make a button look like a link

 Each component introduced its own class, so there's some duplication and
 potential confusion in the use of these classes. The ones I've found are:

 {{{
 /wp-admin/css/press-this.css
 `.button-link`
 `.button-reset`

 /wp-admin/css/customize-nav-menus.css
 `.not-a-button`

 /wp-includes/css/buttons.css
 `.button-link`

 /wp-includes/css/media-views.css
 `.button-link`
 }}}

 I'd propose to consider to move all these classes in `buttons.css`. Also,
 `.button-reset` and `.not-a-button` should probably be merged in just one
 class since they serve the same purpose.
 Finally, `.button-link` would need a review now that the new buttons style
 introduced in #31459 added a default box-shadow that should be reset for
 buttons intended to look like links.

 cc @helen @hugobaeta

 Any thoughts and patches more than welcome :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34242>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform