[wp-trac] [WordPress Trac] #34204: Add fallbacks for WP oEmbed JavaScript & CSS

[WordPress Trac]

#34204: Add fallbacks for WP oEmbed JavaScript & CSS
---------------------------+-------------------------
 Reporter:  peterwilsoncc  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.4
Component:  Embeds         |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  javascript
---------------------------+-------------------------
Changes (by peterwilsoncc):

 * keywords:  has-patch needs-refresh => has-patch
 * type:  enhancement => defect (bug)


Comment:

 Switching the type to bug as the JS was throwing errors in supported
 browsers.

 Refreshed patch added in [attachment:34204.2.diff]:

 * [attachment:embed.zip] new images to be extracted to the directory `src
 /wp-includes/images/embed/`
 * in the iframe:
   - cross browser events - dialog and tabs work back to IE7
   - removed `use strict`, `this` in the event methods generates warnings
 in jshint.
   - feature detection for `focus` & `select`
   - the dialog uses IDs and tags for getting all elements required for
 opening/closing the dialog
   - inputs use `querySelectorAll` and does not add the focus/select events
 in browsers without support
   - styles work back to IE7 but IE7 is ugly. IE8 is surprisingly good.
 * in the embedding JavaScript (`window.top`):
   - JS support only available in browsers supporting `querySelectorAll`
 and modern events.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34204#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform